Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #20

Closed
wants to merge 3 commits into from
Closed

PHP 8.4 compatibility #20

wants to merge 3 commits into from

Conversation

ruudk
Copy link

@ruudk ruudk commented Oct 31, 2024

No description provided.

ruudk added 3 commits October 31, 2024 10:18
> Cloudinary\Transformation\BaseAction::addQualifier(): Implicitly marking parameter $qualifier as nullable is deprecated, the explicit nullable type must be used instead
> Cloudinary\Transformation\QualifierMultiValue::setValue(): Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead

> Cloudinary\Transformation\QualifierMultiValue::setNamedValue(): Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead
@ruudk
Copy link
Author

ruudk commented Oct 31, 2024

@const-cloudinary please approve the workflow

@ruudk
Copy link
Author

ruudk commented Nov 1, 2024

I have a better idea: not use this SDK at all. The interactions we do with it are so little that we can do this via HTTP manually. Closing.

@ruudk ruudk closed this Nov 1, 2024
@ruudk ruudk deleted the patch-1 branch November 1, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant